[mb-bugs] [jira] Commented: (PICARD-14) File path and match % not updated in status bar when saving a single file or updating new metadata

[voiceinsideyou (JIRA)]

    [ http://tickets.musicbrainz.org/browse/PICARD-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124#action_16124 ] 

voiceinsideyou commented on PICARD-14:
--------------------------------------

Hmm, that looks like it could work OK, but I'm not sure about putting window.update stuff off in a separate thread like that. Again, I'm no QT/GUI expert, but isn't the current Picard code modelled around using signals for communication across threads of entity events requiring a GUI repaint/update? This would directly call update on the window in a separate QThread off the save queue, right?

> File path and match % not updated in status bar when saving a single file or updating new metadata
> --------------------------------------------------------------------------------------------------
>
>                 Key: PICARD-14
>                 URL: http://tickets.musicbrainz.org/browse/PICARD-14
>             Project: Picard
>          Issue Type: Bug
>          Components: File Move & Rename, Tags & Metadata, User Interface
>    Affects Versions: 0.15.1
>            Reporter: voiceinsideyou
>            Assignee: Michael Wiencek
>             Fix For: 1.0
>
>         Attachments: PICARD-14.patch
>
>
> If you have a single matched file/track selected in right-hand pane and then save it such that it gets renamed or moved, the status bar is not updated with the new path and match %.
> Additionally, when you manually change "new metadata" values at the bottom of the pane, it does not adjust the match % until you click to another entry and then click back to the file. Ideally I guess it should adjust the % as you type, just as it does for the "similarity bar" icon.
> I think the problem is that AlbumTreeView.update_track does not invoke MainWindow.updateSelection() which has the status-bar-changing logic
> Suggested patch below - but I'm no QT nor GUI expert, so I'm not sure about best approach here. I'm not sure if this will cause too many updates... or possibly whether it should be done after the update_album call?
> {noformat}
> Index: picard/ui/itemviews.py
> ===================================================================
> --- picard/ui/itemviews.py	(revision revno:1173)
> +++ picard/ui/itemviews.py	(revision )
> @@ -684,6 +684,8 @@
>              item.setTextColor(i, color)
>              item.setBackgroundColor(i, get_match_color(similarity, self.palette().base().color()))
>          item.setData(1, QtCore.Qt.UserRole, QtCore.QVariant(track.metadata.length or 0))
> +        if item.isSelected():
> +            self.window.updateSelection(self.panel.selected_objects())
>          if update_album:
>              self.update_album(track.album, update_tracks=False)
>  
> {noformat}

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://tickets.musicbrainz.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira