[mb-devel] libtunepimp, lib64/plugins issue

[Lukáš Lalinský]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

Rex Dieter wrote:
> Rex Dieter wrote:
> 
>> Not sure if this is where to post about libtunepimp, but I think I've
>> found an issue with libtunepimp when built/used on 64 bit systems that
>> typically use /usr/lib64 instead of /usr/lib.
>>
>> lib/tunepimp.cpp defines
>> #define PLUGIN_DIR PREFIX"/lib/tunepimp/plugins"
>> but the top-level Makefile installs to $libdir/tunepimp/plugins.  On
>> Fedora Core/x86_64, for example, libtunepimp is built with
>> ./configure --libdir=/usr/lib64
> 
> Rough draft patch attached.
> 

There are two problems with the patch. The first one is that it's written
against 0.4.x, which I don't think we want to add any functionality to. But it
could be easily ported to 0.5.x, so that's not the main problem.

Bigger problem is that you are patching generated files. Makefile.in's are
automatically generated from Makefile.am's by Automake.

- -Lukáš
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.4 (MingW32)

iD8DBQFFHYoVOjmgKpITL3sRAk4yAKC725LQ3y8Gp3V4kHNMn/vIEy7AOQCgiTjc
t6C+nFLbkTLT9zvrIRIVpMc=
=/tNe
-----END PGP SIGNATURE-----