[mb-devel] PicardQt: PUID generation broken on big endian machines

[Lukáš Lalinský]

On Ut, 2007-07-10 at 22:20 +0200, Juergen Kreileder wrote:
> Hi,
> 
> PicardQt doesn't generate correct PUIDs on big endian machines. I've
> seen the problem on Linux/ppc and OS X/ppc.
> 
> I get correct PUIDs when I replace OFA_LITTLE_ENDIAN with OFA_BIG_ENDIAN
> in picard/musicdns/ofa.c.
> 
> I'm not 100% sure whether this code just depends on the machine
> endianess, so I don't provide a patch.  But you definitely should add an
> endian check somewhere.

The code depends on endianess of the audio decoder. I was expecting
ffmpeg will always return LE data, even on BE machines. I'll try to
find out some way to check in which endian is ffmpeg returning the
data.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Toto je =?ISO-8859-1?Q?digit=E1lne?=
	=?ISO-8859-1?Q?_podp=EDsan=E1?= =?UTF-8?Q?_=C4=8Das=C5=A5?=
	=?ISO-8859-1?Q?_spr=E1vy?=
Url : http://lists.musicbrainz.org/pipermail/musicbrainz-devel/attachments/20070710/88a5b50b/attachment.pgp