[mb-devel] libmusicbrainz-3.0.0 Build Issue in src/disc.cpp?

[Lukáš Lalinský]

On Po, 2007-05-28 at 15:42 -0500, David Stockwell wrote: 
> Ladies and Gents...
>  
> After building libmusicbrainz-3.0.0, every time I attempt to readDisc,
> it throws "libdiscid is not available".
>  
> Reviewing the code, I see that this is because HAVE_DISCID was not
> defined when building the library, in compiling disc.cpp.  I cannot
> see anything in the Install documentation that indicates where/how to
> set HAVE_DISCID.
>  
> For what it is worth, it is clear that DISCID_FOUND is set in cmake.

It's a bug, it should use only DISCID_FOUND -
http://bugs.musicbrainz.org/changeset/9177

For now you can use:

cmake -DCMAKE_CXX_FLAGS:STRING="-DHAVE_DISCID" .

> It is also suspicious that the #DEFINE in discid/discid.h sets
> MUSICBRAINZ_DISC_ID_H, and I am wondering if this is what should have
> been used instead of HAVE_DISCID in disc.cpp?

Nope, MUSICBRAINZ_DISC_ID_H is defined just to prevent double inclusion
of the header file.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Toto je =?ISO-8859-1?Q?digit=E1lne?=
	=?ISO-8859-1?Q?_podp=EDsan=E1?= =?UTF-8?Q?_=C4=8Das=C5=A5?=
	=?ISO-8859-1?Q?_spr=E1vy?=
Url : http://lists.musicbrainz.org/pipermail/musicbrainz-devel/attachments/20070529/97560c65/attachment.pgp