Announcing MB Tagger! (Re: music catalog clients)

[Robert Kaye]

On Wed, 2002-01-30 at 01:30, Johan Pouwelse wrote:
> Robert Kaye wrote:
> > On Mon, 2002-01-28 at 04:00, Johan Pouwelse wrote:
> > As usual I'm hoping that people will pick up and extend the source code
> > -- no question about that. But, given that its written in BC++, I don't
> > know how many people will be able to work on it as is.
> 
> BC++ is a strong drawback. The idea of Myers to use the platform independant
> windows tools is great. This would also mean re-do all your work.

BC++ is only a drawback if you expect lots of people to jump in and
contribute code. But so far that hasn't been a problem. ;-) I'd love to
see some other tools provide a better service than the MB Tagger does.
Until that time, we have the MB tagger to work with...

> May I suggest creating a common MP3_signature_musicbrainz lib first and take
> it from there.
> 
> OK, I'm now also too tired of half finished up tools. I will halt my work on the
> winamp SyncText client and will produce a MP3_signature_musicbrainz lib within 2
> weeks.

Ok, sounds good. You should be able to take large chunks of the MB
Tagger code to make this happen.

> -include a _single_ HTTP(S) class with proxy feature that is used by:
>   *TRM code
>   *MB code
>   *Secure login to post TRMids on server

Why do you need this? The mb_client lib already has all this (except for
the secure login stuff, but that is mostly done) You should just be able
to use the mb_client and not worry about net connectivity stuff...

> The final feature is the upload of new TRMids and DiscIDs to the server. The
> secure login and passwd encryption is not my area of expertise, Rob can you
> perhaps put that at the top of your ToDo list? For the server side I can also
> write: the database insert stuff and the moderation code with showing the last
> 100 insert that can be moderated.

I'll take care of the server issues -- why don't you just worry about
the client side? And as I mentioned above, just use the submission stuff
that will be in the mb_client lib soon.

> For the generic interface I have the following idea:
> 
> struct *metadata identify_files(struct *options, *locations[]);
> 
> The locations variable contains the filenames and/or directory names to search.
> Options contains the recursive On/Off, login name and plain text password of the
> moderator account on MB, etc.
> The metadata struct contains the information on all the locations
> 
> struct options {
>  bool cdrom_or_file_mode  (switch between TRMids/DiscIds, location must contain
> drive)
>  bool recursive_mode
>  bool blocking_mode   (non-blocking mode means fork() do in background)

Don't use fork. Please use threads.

>  bool upload_info_to_server
>  bool rewrite_ID3_tags_in_files
>  char *moderator_name
>  char *passwd
>  char *relatable_server  (default beta.relatable.com)
>  char *musicbrainz_server (default musicbrainz.org)
>  char *proxy_settings;
>  etc.
> }

> int report_progress(char *current_file, char *message, int max_length); 
> When non-blocking mode is selected in the options this function can be used to
> obtain a message string from the lib. The message will contain tings such as:
> 45.8% of MP3 decoded, contacting Relatable.com, etc.
> The report_progress function returns '1' when all files are completed and '0'
> when still in busy.

Sounds good.

> struct *metadata get_results();
> 
> In non-blocking mode the results can be obtained by calling this function. This
> function can only be used when report_progress==1, otherwise it returns NULL.
> 
> 
> Is this a good plan people? Please provide some feedback.

Sounds good -- just be careful to not duplicate features that are
already in mb_client. If the features in mb_client are not there or ill
fitting, then let's tweak the mb_client rather than duplicating
features.

-- 

--ruaok         Freezerburn! All else is only icing. -- Soul Coughing

Robert Kaye   --    rob at eorbit.net   --   http://www.mayhem-chaos.net

_______________________________________________
Musicbrainz mailing list
Musicbrainz at musicbrainz.org
http://www.musicbrainz.org/mailman/listinfo/musicbrainz